busybox
Inverted if usage in ENABLE_DESKTOP If ENABLE_DESKTOP is not set, BusyBox displays a message. But, note that this functionality is inverted. Actually, BusyBox needs to print any message only when ENABLE_DESKTOP is enabled.
Bug fixed by commit df7b6577c6a
| Type | BehaviorViolation |
| Config | !DESKTOP (1st degree) |
| Fix-in | mapping |
| Location | coreutils/ |
#include <stdio.h>
int main(int argc, char** argv)
{
int n = -1;
if (n < 0) { /* error in get_groups() */
#ifndef ENABLE_DESKTOP
printf("can't get groups");
#else
return EXIT_FAILURE;
#endif
}
return 0;
}
diff --git a/simple/df7b657.c b/simple/df7b657.c
--- a/simple/df7b657.c
+++ b/simple/df7b657.c
@@ -6,7 +6,7 @@
int n = -1;
if (n < 0) { /* error in get_groups() */
-#ifndef ENABLE_DESKTOP
+#ifdef ENABLE_DESKTOP
printf("can't get groups");
#else
return EXIT_FAILURE;
#include <stdio.h>
int main(int argc, char** argv)
{
int n = -1;
if (n < 0) { /* error in get_groups() */
#ifndef ENABLE_DESKTOP
printf("can't get groups");
#else
return EXIT_FAILURE;
#endif
}
return 0;
}
. [!ENABLE_DESKTOP] coreutils/id.c:180:bb_error_msg_and_die()